[libcxx-commits] [PATCH] D119445: [libc++] Use std::ranges::swap_ranges in swap CPO

Thu Feb 10 15:35:49 PST 2022

jloser added a comment.

In D119445#3311448 <https://reviews.llvm.org/D119445#3311448>, @Quuxplusone wrote:

> LGTM if CI is happy. I skimmed the existing tests for `ranges::swap` and it looks like arrays are covered decently well; but have you also looked at the tests? Do we need any more coverage for this?

Looks like CI isn't happy as this introduces a header cycle as shown by https://buildkite.com/llvm-project/libcxx-ci/builds/8635#9ef9a18c-716c-4962-9f54-27108fa79d51. We'll need to fix that.

As for the tests, I briefly looked at the array tests and they seemed OK - nothing immediately came to mind that I'd like to add (at least as a result of us using `ranges::swap_ranges` for swappable arrays).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119445/new/

https://reviews.llvm.org/D119445