[libcxx-commits] [PATCH] D118736: [libc++] Guard std::ranges under _LIBCPP_HAS_NO_INCOMPLETE_RANGES.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, however:

1. I would really prefer not opening namespace `std` when testing that we don't define `std::ranges`, since that's technically ill-formed.
2. Consider applying @Mordante 's comment about getting rid of `_LIBCPP_` macros inside the tests.

Let's ship this ASAP and I can cherry-pick it onto `release/14.x`. Thanks a lot for handling this -- we definitely didn't want to ship LLVM 14 without having this under control, since that could have removed our ability to improve several things in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118736/new/

https://reviews.llvm.org/D118736