[libcxx-commits] [PATCH] D118736: [libc++] Guard std::ranges under _LIBCPP_HAS_NO_INCOMPLETE_RANGES.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I didn't look to closely at the patch, but one suggestion.



================
Comment at: libcxx/test/std/containers/views/span.cons/deduct.pass.cpp:89
 
+#ifndef _LIBCPP_HAS_NO_INCOMPLETE_RANGES
 void test_range_std_container() {
----------------
I'm working on removing `_LIBCPP_FOO` from the tests, can you add a `TEST_HAS_NO_INCOMPLETE_RANGES` in `test_macros.h` and use that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118736/new/

https://reviews.llvm.org/D118736