[libcxx-commits] [PATCH] D119687: [libc++] [test] Improve the tests for std::{begin, end}(valarray).

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D119687#3319906 <https://reviews.llvm.org/D119687#3319906>, @EricWF wrote:

> There's a bunch of functions that were previously tested here that are no longer. What's up with that?

Such as? I see the reverse — `begin(const valarray<T>&)` was never tested on the left-hand side, but it //is// tested on the right-hand side.

> The test suite has typically been structured so that each overload gets its own test file. Your changes undo this. Can you state why you believe this to be an improvement?

Consistency with D119677 <https://reviews.llvm.org/D119677>, and making sure we test every one of the four functions in the same way.
The original raison d'etre here was just to get rid of the unqualified ADL calls to `begin` and `end`, and make sure we're spelling them `std::begin` and `std::end` in this directory. The rest of the cleanup was just "as long as I'm here."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119687/new/

https://reviews.llvm.org/D119687