[libcxx-commits] [PATCH] D119687: [libc++] [test] Improve the tests for std::{begin, end}(valarray).

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 14 10:38:48 PST 2022


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

There's a bunch of functions that were previously tested here that are no longer. What's up with that?

The test suite has typically been structured so that each overload gets its own test file. Your changes undo this. Can you state why you believe this to be an improvement?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119687/new/

https://reviews.llvm.org/D119687



More information about the libcxx-commits mailing list