[libcxx-commits] [PATCH] D119573: [libcxx] [ci] Enable LIBCXX_ENABLE_WERROR where possible

Sat Feb 12 11:41:07 PST 2022

mstorsjo added a comment.

In D119573#3317080 <https://reviews.llvm.org/D119573#3317080>, @Mordante wrote:

> In D119573#3315185 <https://reviews.llvm.org/D119573#3315185>, @philnik wrote:
>
>> I think you should put the `-DLIBCXX_ENABLE_WERROR=NO` in the cmake cache files.
>
> I prefer not to for the reasons @mstorsjo mentioned. I love using `-Werror`, but I feel it should always be an opt-in.
> I want to see the CI green before approving.

Yep, I noticed that there were some more warnings in the Ryu code. (I had tested building with clang-cl for aarch64, where those warnings weren't present.) I'll soon post a patch that should silence them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119573/new/

https://reviews.llvm.org/D119573