[libcxx-commits] [PATCH] D119573: [libcxx] [ci] Enable LIBCXX_ENABLE_WERROR where possible

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D119573#3315185 <https://reviews.llvm.org/D119573#3315185>, @philnik wrote:

> I think you should put the `-DLIBCXX_ENABLE_WERROR=NO` in the cmake cache files.

I prefer not to for the reasons @mstorsjo mentioned. I love using `-Werror`, but I feel it should always be an opt-in.
I want to see the CI green before approving.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119573/new/

https://reviews.llvm.org/D119573