[libcxx-commits] [PATCH] D119430: [libcxx] Wrap [[no_unique_address]] in a macro, for clang-cl

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo marked 2 inline comments as done.
mstorsjo added inline comments.


================
Comment at: libcxx/include/__ranges/join_view.h:71
+    _LIBCPP_NO_UNIQUE_ADDRESS _Cache __cache_;
+    _View __base_ = _View(); // TODO: _LIBCPP_NO_UNIQUE_ADDRESS makes clang crash! File a bug :)
 
----------------
philnik wrote:
> I'd personally keep `[[no_unique_address]]` here.
Oh, oops. Yes this is a victim of search-and-replace...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119430/new/

https://reviews.llvm.org/D119430