[libcxx-commits] [PATCH] D119430: [libcxx] Wrap [[no_unique_address]] in a macro, for clang-cl

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 10 05:30:04 PST 2022


mstorsjo added a comment.

With this (and D119134 <https://reviews.llvm.org/D119134>) I think we could enable `LIBCXX_ENABLE_WERROR` in all CI configurations except for the couple GCC ones.

GCC builds seem to print (at least) this warning when building:

  include/c++/v1/string:2267:32: error: enumerated and non-enumerated type in conditional expression [-Werror=extra]
   2267 |   size_type __cap = __is_short ? __min_cap : __get_long_cap();


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119430/new/

https://reviews.llvm.org/D119430



More information about the libcxx-commits mailing list