[libcxx-commits] [PATCH] D119264: [libc++] Rename *SAFE_STATIC to *CONSTINIT, and normalize its uses.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 9 08:23:51 PST 2022


Mordante accepted this revision.
Mordante added a comment.

Thanks for the cleanup! LGTM!



================
Comment at: libcxx/src/debug.cpp:38
 
-_LIBCPP_SAFE_STATIC __libcpp_debug_function_type
+_LIBCPP_CONSTINIT __libcpp_debug_function_type
     __libcpp_debug_function = __libcpp_abort_debug_function;
----------------
As @ldionne already pointed out we require C++20 to build the dylib so I would suggest to use `constinit` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119264/new/

https://reviews.llvm.org/D119264



More information about the libcxx-commits mailing list