[libcxx-commits] [PATCH] D119264: [libc++] Rename *SAFE_STATIC to *CONSTINIT, and normalize its uses.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 8 14:08:07 PST 2022
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM in essence, however some tests are failing. Also, we are free to assume C++20 the we build the library (in `src/`), because we require it here: https://github.com/llvm/llvm-project/blob/main/libcxx/CMakeLists.txt#L538-L541.
Ship it when this passes, and I suggest you use `constinit` directly in `src/`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119264/new/
https://reviews.llvm.org/D119264
More information about the libcxx-commits
mailing list