[libcxx-commits] [PATCH] D119173: [libc++] Remove _LIBCPP_ABI_UNSTABLE

[Roman Lebedev via Phabricator via libcxx-commits]

lebedev.ri added inline comments.


================
Comment at: libcxx/CMakeLists.txt:190-192
+if (NOT LIBCXX_ABI_NAMESPACE MATCHES "__.*")
+  message(FATAL_ERROR "LIBCXX_ABI_NAMESPACE must be a reserved identifier.")
+endif()
----------------
This requires build dir purge and cmake rerun,
because `LIBCXX_ABI_NAMESPACE` would be `""` (empty) before,
and you don't force-recover it to `"__${LIBCXX_ABI_VERSION}"`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119173/new/

https://reviews.llvm.org/D119173