[libcxx-commits] [PATCH] D119173: [libc++] Remove _LIBCPP_ABI_UNSTABLE

Tue Feb 8 18:24:13 PST 2022

paulkirth added a comment.

Hi,

We're seeing breakage in Fuchsia's Clang canary builders for Linux (aarch64 & X86_64) that seem related to this patch, (though it may be related to D119036 <https://reviews.llvm.org/D119036> ? I can't tell).

Sorry for the late notification. This was hidden by a breakage in an different LLVM component, so we missed this for a bit.

We're seeing errors of this nature:

  In file included from /b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/libcxx/containers/sequences/deque/incomplete.pass.cpp:16:
  In file included from /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/deque:163:
  /b/s/w/ir/x/w/staging/llvm_build/include/c++/v1/__config:64:11: error: '_LIBCPP_ABI_INCOMPLETE_TYPES_IN_DEQUE' macro redefined [-Werror,-Wmacro-redefined]
  #  define _LIBCPP_ABI_INCOMPLETE_TYPES_IN_DEQUE
            ^
  <command line>:6:9: note: previous definition is here
  #define _LIBCPP_ABI_INCOMPLETE_TYPES_IN_DEQUE 1

You can find the builders here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8822761889490955361/overview 
the failing test in Clang :: CodeGen/aarch64-mops.c has already been addressed and is unrelated.

and newer ones here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8822749181186387249/overview

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119173/new/

https://reviews.llvm.org/D119173