[libcxx-commits] [PATCH] D119123: [libc++] Prepare string.{access, capacity, cons} tests for constexpr

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/std/strings/basic.string/string.capacity/empty.pass.cpp:27
 
-int main(int, char**)
-{
-    {
+bool test() {
+  {
----------------
philnik wrote:
> ldionne wrote:
> > Missing `TEST_CONSTEXPR_CXX20`.
> The problem is that clang will warn on these. They aren't templates, so they have to be made `constexpr` with the functional changes.
Oh, of course. Otherwise Clang complains about a constexpr function never being constexpr-friendly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119123/new/

https://reviews.llvm.org/D119123