[libcxx-commits] [PATCH] D119123: [libc++] Prepare string.{access, capacity, cons} tests for constexpr

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

@ldionne No, they aren't all the changes, but most of them. I first want to make these very easy to verify changes and then the actual behavioral changes.
I think most of the rest are ignoring exception tests during constant evaluation, but I think it will be easier for everybody if I put all the `else if (!TEST_IS_CONSTANT_EVALUATED)` into a single PR.



================
Comment at: libcxx/test/std/strings/basic.string/string.capacity/empty.pass.cpp:27
 
-int main(int, char**)
-{
-    {
+bool test() {
+  {
----------------
ldionne wrote:
> Missing `TEST_CONSTEXPR_CXX20`.
The problem is that clang will warn on these. They aren't templates, so they have to be made `constexpr` with the functional changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119123/new/

https://reviews.llvm.org/D119123