[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/libcxx/lint/lint_headers.sh.py:59
-            else:
-                prevline = None
     assert okay
----------------
I'd still very strongly prefer to keep these 12 lines, as a check against clang-tidy's behavior (which we're not sure what it is). After all, right now it's //possible// that clang-tidy doesn't check include order at all; or checks it only in the public headers; or fails to check anything not-included or guarded under an `#ifdef`. (And more importantly from the engineering POV, we don't know if it will behave the same 3 years from now.)
However, removing these 12 lines is at least //acceptable//, as a conscious compromise to get D117174 closed out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174