[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

> Is there any way to check if the nodes have clang-tidy installed without re-running CI?

Unfortunately, no.

@Quuxplusone
Honestly, I don't understand the objection with removing the part of `lint_headers.py` that deals with include ordering. IMO, we should remove it (as the current patch does) and change the top-level comment from

  # Verify that each run of consecutive #include directives
  # in each libcxx/include/ header is maintained in alphabetical order.

to something like

  # This script contains a few consistency checks for the libc++ headers that
  # can't be enforced with clang-tidy, such as checking that we use
  # pragma system_header consistently, etc.

We normally strive to have one canonical way of doing things, and the canonical way of checking for include order is to use `clang-tidy`. We don't need a second one -- I think the only thing it adds is potential for confusion.

The only argument I could imagine in favour of this is that it allows "dropping" a dependency on `clang-tidy` for local development, however I think we should actually go the other way and encourage people to install clang-tidy so that this test is run locally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174