[libcxx-commits] [PATCH] D118733: [libc++] Remove the std::string base class

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D118733#3295008 <https://reviews.llvm.org/D118733#3295008>, @ldionne wrote:

> Oooooh, I'm trembling to approve this. If my reasoning on `vector_base_common` isn't right, this is going to break the whole world (`basic_string` is like the most used type in the library). But yeah, we've thought it out and it seems legit, so let's go.

What could go wrong? The worst would be that we break thousands of people's software silently :D
Do you cherry-pick the commit onto the release branch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118733/new/

https://reviews.llvm.org/D118733