[libcxx-commits] [PATCH] D118733: [libc++] Remove the std::string base class

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 3 13:52:57 PST 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Oooooh, I'm trembling to approve this. If my reasoning on `vector_base_common` isn't right, this is going to break the whole world (`basic_string` is like the most used type in the library). But yeah, we've thought it out and it seems legit, so let's go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118733/new/

https://reviews.llvm.org/D118733



More information about the libcxx-commits mailing list