[libcxx-commits] [PATCH] D118809: [libc++] Define `namespace views` in its own detail header.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/CMakeLists.txt:353
   __ranges/view_interface.h
+  __ranges/views.h
   __split_buffer
----------------
ldionne wrote:
> `views_namespace.h` or `namespace_views.h`? Just `views.h` makes it look like it is an umbrella header for including all views at once.
`__ranges/namespace_views.h` wouldn't be the end of the world, but it would be oddly inconsistent with the usual convention of naming the header after the library name it defines. The header that defines the-thing-named-`views` //should// be named `views.h`, IMO.
(This is our convention with the notable exception of `__ranges/access.h`, which I've tried to disentangle before and found it's sadly really difficult.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118809/new/

https://reviews.llvm.org/D118809