[libcxx-commits] [PATCH] D118809: [libc++] Define `namespace views` in its own detail header.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 14:23:09 PST 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but I think we can pick a better name for the header.



================
Comment at: libcxx/include/CMakeLists.txt:353
   __ranges/view_interface.h
+  __ranges/views.h
   __split_buffer
----------------
`views_namespace.h` or `namespace_views.h`? Just `views.h` makes it look like it is an umbrella header for including all views at once.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118809/new/

https://reviews.llvm.org/D118809



More information about the libcxx-commits mailing list