[libcxx-commits] [PATCH] D118800: [libc++] Normalize all our '#pragma GCC system_header', and regression-test.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 09:43:14 PST 2022


Mordante requested changes to this revision.
Mordante added a comment.

Let's first agree on how the we want to format `#pragma GCC system_header\n`.



================
Comment at: libcxx/include/__format/formatter_pointer.h:27
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
-#  pragma GCC system_header
 #endif
----------------
The spaces in the `#if` is something we recently changed in the `.clang-format` file on @ldionne's request https://reviews.llvm.org/D103368#inline-1043939. So I would prefer to keep it that way. If we agree to remove the spaces, please also update the `.clang-format`. I know we don't use clang-format, but I've been using it in the formatter code since its inception and I prefer to keep using it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118800/new/

https://reviews.llvm.org/D118800



More information about the libcxx-commits mailing list