[libcxx-commits] [PATCH] D118800: [libc++] Normalize all our '#pragma GCC system_header', and regression-test.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

This LGTM, but I care strongly that we indent nested preprocessor directives. This is not different from indenting normal if-else chains.

In a 3-line `#if`, this is not so bad, however when we start having complicated nested conditions like we do in `__config`, it's basically impossible to read unless things are indented properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118800/new/

https://reviews.llvm.org/D118800