[libcxx-commits] [PATCH] D118800: [libc++] Normalize all our '#pragma GCC system_header', and regression-test.

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 08:33:12 PST 2022


jloser accepted this revision.
jloser added inline comments.


================
Comment at: libcxx/test/libcxx/lint/lint_headers.sh.py:46
+                okay = False
+                print('FAILED TO FIND #pragma GCC system_header in libcxx/include/%s!' % pretty(fname))
+
----------------
Nit: I think we rely on `python3` exclusively now, so we could make this a Python3 f-string which I think is nicer. Thoughts? I hear the argument that this is consistent with the rest of the file (because it was mostly written when we only supported Python2).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118800/new/

https://reviews.llvm.org/D118800



More information about the libcxx-commits mailing list