[libcxx-commits] [PATCH] D118800: [libc++] Normalize all our '#pragma GCC system_header', and regression-test.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 2 08:07:13 PST 2022


Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, philnik, var-const, jloser, Mordante, libc++.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Now we'll notice if a header forgets to include this magic phrase.

(I'm sympathetic to the argument that we should add a //new// linter test for each different check, instead of piggybacking every check into `lint_headers.py` (which we could rename to indicate that it checks nothing but include-ordering). However, I don't think we've reached the tipping point of complexity yet. :))


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118800

Files:
  libcxx/include/__availability
  libcxx/include/__bit/byteswap.h
  libcxx/include/__filesystem/copy_options.h
  libcxx/include/__filesystem/directory_entry.h
  libcxx/include/__filesystem/directory_iterator.h
  libcxx/include/__filesystem/directory_options.h
  libcxx/include/__filesystem/file_status.h
  libcxx/include/__filesystem/file_time_type.h
  libcxx/include/__filesystem/file_type.h
  libcxx/include/__filesystem/filesystem_error.h
  libcxx/include/__filesystem/operations.h
  libcxx/include/__filesystem/path.h
  libcxx/include/__filesystem/path_iterator.h
  libcxx/include/__filesystem/perm_options.h
  libcxx/include/__filesystem/perms.h
  libcxx/include/__filesystem/recursive_directory_iterator.h
  libcxx/include/__filesystem/space_info.h
  libcxx/include/__filesystem/u8path.h
  libcxx/include/__format/format_to_n_result.h
  libcxx/include/__format/formatter_floating_point.h
  libcxx/include/__format/formatter_pointer.h
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/include/__iterator/indirectly_comparable.h
  libcxx/include/__memory/voidify.h
  libcxx/include/__numeric/adjacent_difference.h
  libcxx/include/__numeric/exclusive_scan.h
  libcxx/include/__numeric/gcd_lcm.h
  libcxx/include/__numeric/inclusive_scan.h
  libcxx/include/__numeric/iota.h
  libcxx/include/__numeric/midpoint.h
  libcxx/include/__numeric/partial_sum.h
  libcxx/include/__numeric/reduce.h
  libcxx/include/__numeric/transform_exclusive_scan.h
  libcxx/include/__numeric/transform_inclusive_scan.h
  libcxx/include/__numeric/transform_reduce.h
  libcxx/include/locale.h
  libcxx/test/libcxx/lint/lint_headers.sh.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118800.405287.patch
Type: text/x-patch
Size: 16012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220202/cdc8f797/attachment.bin>


More information about the libcxx-commits mailing list