[libcxx-commits] [PATCH] D118740: [libc++] Add CI without experimental features and don't exclude span from the tests

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 1 15:02:45 PST 2022


ldionne added inline comments.


================
Comment at: libcxx/test/std/containers/views/span.cons/deduct.pass.cpp:10
 // UNSUPPORTED: libcpp-no-concepts
-// UNSUPPORTED: libcpp-has-no-incomplete-ranges
 
----------------
jloser wrote:
> If we remove this, do we need to replace it with `XFAIL: apple-clang-12.0.0`?  This goes for other span tests too, but most (all but this one?) have the `XFAIL` already.
I don't think we need the XFAIL here because we are not using concepts in this test AFAICS. CI will let us know if we need to add it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118740/new/

https://reviews.llvm.org/D118740



More information about the libcxx-commits mailing list