[libcxx-commits] [PATCH] D118740: [libc++] Add CI without experimental features and don't exclude span from the tests

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 1 14:47:56 PST 2022


jloser added a comment.

Looks reasonable to me modulo my comment about missing the `XFAIL: apple-clang-12.0.0` on `libcxx/test/std/containers/views/span.cons/deduct.pass.cpp`



================
Comment at: libcxx/test/std/containers/views/span.cons/deduct.pass.cpp:10
 // UNSUPPORTED: libcpp-no-concepts
-// UNSUPPORTED: libcpp-has-no-incomplete-ranges
 
----------------
If we remove this, do we need to replace it with `XFAIL: apple-clang-12.0.0`?  This goes for other span tests too, but most (all but this one?) have the `XFAIL` already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118740/new/

https://reviews.llvm.org/D118740



More information about the libcxx-commits mailing list