[libcxx-commits] [PATCH] D140568: [libc++] LWG3738 Validates a missing precondition.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/include/__ranges/take_view.h:69
+      : __base_(std::move(__base)), __count_(__count) {
+    _LIBCPP_ASSERT(__count >= 0, "precondition failure");
+  }
----------------
philnik wrote:
> Maybe something like "count has to be greater or equal to zero", to be a bit more descriptive?
I think the condition tells the same, but no strong objection against the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140568/new/

https://reviews.llvm.org/D140568