[libcxx-commits] [PATCH] D140568: [libc++] LWG3738 Validates a missing precondition.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM with comments addressed and green CI.



================
Comment at: libcxx/include/__ranges/take_view.h:18
 #include <__config>
+#include <__debug>
 #include <__functional/bind_back.h>
----------------
This should be `<__assert>`, right?


================
Comment at: libcxx/include/__ranges/take_view.h:69
+      : __base_(std::move(__base)), __count_(__count) {
+    _LIBCPP_ASSERT(__count >= 0, "precondition failure");
+  }
----------------
Maybe something like "count has to be greater or equal to zero", to be a bit more descriptive?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140568/new/

https://reviews.llvm.org/D140568