[libcxx-commits] [PATCH] D140453: [libc++] Remove HIDE_FROM_ABI from virtual functions

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

I also feel clang-query is really useful. This change really convinces me to spend some time with it too.
LGTM!



================
Comment at: libcxx/test/libcxx/clang_query/abi_tag_on_virtual.query:23
+#
+# This test ensures that we don't re-introduce this issue in the code base.
+
----------------
Nice comment!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140453/new/

https://reviews.llvm.org/D140453