[libcxx-commits] [PATCH] D140453: [libc++] Remove HIDE_FROM_ABI from virtual functions

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D140453#4010549 <https://reviews.llvm.org/D140453#4010549>, @philnik wrote:

>   match
>   cxxMethodDecl(isVirtual(),
>                 hasAttr("attr::AbiTag"),
>                 unless(isExpansionInSystemHeader())
>                )
>
> should do the trick (using clang-query for now). Looking at the CI failures I'm not sure just removing the `_LIBCPP_HIDE_FROM_ABI` is the right call here. Maybe we need something like `_LIBCPP_HIDE_VIRTUAL_FUNCTION_FROM_ABI` that gives the functions internal linkage. That didn't suffer from this problem, right? (And also maybe mention the problem in the `_LIBCPP_HIDE_FROM_ABI` explanation in `<__config>`.)

Thanks a lot, this is magic. It actually found many more instances of the same problem! This tool is really growing on me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140453/new/

https://reviews.llvm.org/D140453