[libcxx-commits] [PATCH] D128084: [libc++] Add CI job testing on FreeBSD

[Ed Maste via Phabricator via libcxx-commits]

emaste added a comment.

With the XFAILS from this review added I'm seeing `Failed Tests (494)`

Many of these are compile failures while building the test code, e.g.

  ******************** TEST 'llvm-libc++-shared.cfg.in :: libcxx/utilities/format/version.compile.pass.cpp' FAILED ********************^M
  Script:^M
  --^M
  : 'COMPILED WITH';  /usr/bin/c++ /usr/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/libcxx/test/libcxx/utilities/format/version.compile.pass.cpp  --target=x86_64-unknown-freebsd13.1 -nostdinc++ -I /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings  -fsyntax-only^M
  --^M
  Exit Code: 1^M
  ^M
  Command Output (stdout):^M
  --^M
  $ ":" "COMPILED WITH"^M
  note: command had no output on stdout or stderr^M
  $ "/usr/bin/c++" "/usr/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/libcxx/test/libcxx/utilities/format/version.compile.pass.cpp" "--target=x86_64-unknown-freebsd13.1" "-nostdinc++" "-I" "/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1" "-I" "/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1" "-I" "/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/libcxx/test/support" "-std=c++2b" "-Werror" "-Wall" "-Wctad-maybe-unsupported" "-Wextra" "-Wshadow" "-Wundef" "-Wno-unused-command-line-argument" "-Wno-attributes" "-Wno-pessimizing-move" "-Wno-c++11-extensions" "-Wno-noexcept-type" "-Wno-atomic-alignment" "-Wno-user-defined-literals" "-Wno-tautological-compare" "-Wsign-compare" "-Wunused-variable" "-Wunused-parameter" "-Wunreachable-code" "-Wno-unused-local-typedef" "-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER" "-D_LIBCPP_ENABLE_EXPERIMENTAL" "-D_LIBCPP_DISABLE_AVAILABILITY" "-fcoroutines-ts" "-Werror=thread-safety" "-Wuser-defined-warnings" "-fsyntax-only"^M
  # command stderr:^M
  In file included from /usr/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/libcxx/test/libcxx/utilities/format/version.compile.pass.cpp:13:^M
  In file included from /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/format:182:^M
  In file included from /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/format_functions.h:33:^M
  In file included from /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_bool.h:21:^M
  In file included from /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_integral.h:18:^M
  /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_output.h:376:1: error: anonymous structs and classes must be class members^M
  struct __null_sentinel {};^M
  ^^M
  /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_output.h:376:1: error: declaration does not declare anything [-Werror,-Wmissing-declarations]^M
  /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_output.h:379:61: error: expected parameter declarator^M
  _LIBCPP_HIDE_FROM_ABI bool operator==(const _CharT* __cstr, __null_sentinel) {^M
                                                              ^^M
  /usr/include/sys/cdefs.h:454:25: note: expanded from macro '__null_sentinel'^M
  #define __null_sentinel __attribute__((__sentinel__))^M
                          ^^M
  In file included from /usr/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/libcxx/test/libcxx/utilities/format/version.compile.pass.cpp:13:^M
  In file included from /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/format:182:^M
  In file included from /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/format_functions.h:33:^M
  In file included from /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_bool.h:21:^M
  In file included from /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_integral.h:18:^M
  /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_output.h:379:28: error: overloaded 'operator==' must be a binary operator (has 1 parameter)^M
  _LIBCPP_HIDE_FROM_ABI bool operator==(const _CharT* __cstr, __null_sentinel) {^M
                             ^^M
  /home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/__format/formatter_output.h:387:31: error: expected expression^M
    std::ranges::copy(__prefix, __null_sentinel{}, __out_it);^M
                                ^^M
  /usr/include/sys/cdefs.h:454:25: note: expanded from macro '__null_sentinel'^M
  #define __null_sentinel __attribute__((__sentinel__))^M
                          ^^M
  5 errors generated.^M
  ^M
  error: command failed with exit status: 1^M
  ^M
  --^M
  ^M
  ********************^M


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128084/new/

https://reviews.llvm.org/D128084