[libcxx-commits] [PATCH] D128084: [libc++] Add CI job testing on FreeBSD

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/utils/libcxx/test/features.py:257
+  Feature(name='freebsd', when=lambda cfg: '__FreeBSD__' in compilerMacros(cfg)),
+  Feature(name='LIBCXX-FREEBSD-FIXME', when=lambda cfg: '__FreeBSD__' in compilerMacros(cfg))
 ]
----------------
emaste wrote:
> The intent of this one is to tag specifically those XFAILs added as part of enabling CI? There is one case of `XFAIL: freebsd` in the tree now (trivial_copy_move_ABI.pass.cpp).
Yeah, this is just that the test fails for //some// reason. IOW they should be worked through after this patch is landed and checked whether to convert the `XFAIL: LIBCXX-FREEBSD-FIXME` to an `XFAIL: freebsd` if the failure is expected/wanted, or fix the test/library that is broken. Looking at the list, `std::filesystem` probably just isn't implemented on FreeBSD and the `locale` tests will have to be modified because it's the least portable portable interface ever.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128084/new/

https://reviews.llvm.org/D128084