[libcxx-commits] [PATCH] D128084: [libc++] Add CI job testing on FreeBSD

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__config:134
 // are deprecated.
-#    if defined(__FreeBSD__)
+#    if defined(__FreeBSD__) && !defined(_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR)
 #      define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR
----------------
emaste wrote:
> emaste wrote:
> > should this part be committed independently?
> Can we commit this separately first?
I'm sure we can. Just create a patch; though I don't understand why this change is even needed. 


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/last_write_time.pass.cpp:9
 
+// XFAIL: LIBCXX-FREEBSD-FIXME
+
----------------
emaste wrote:
> fails to apply, `// XFAIL: LIBCXX-AIX-FIXME` has been added here (and neg_format.pass.cpp, pos_format.pass.cpp, thousands_sep.pass.cpp, get_one_wide.pass.cpp, get_one.pass.cpp)
> 
> will deal with this once buildkite is sorted out
You should be able to apply the patch with `arc patch D128084` and then rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128084/new/

https://reviews.llvm.org/D128084