[libcxx-commits] [PATCH] D128084: [libc++] Add CI job testing on FreeBSD

Wed Dec 14 13:12:38 PST 2022

emaste added a comment.

buildkite reports

  $ trap 'kill -- $$' INT TERM QUIT; libcxx/utils/ci/generate-buildkite-pipeline | buildkite-agent pipeline upload
  2022-12-14 21:08:55 INFO   Reading pipeline config from STDIN
  2022-12-14 21:08:56 INFO   Updating BUILDKITE_COMMIT to "421692721d91d2db7d2d24f299239eaecbfc1a89"
  2022-12-14 21:08:56 FATAL  Pipeline parsing of "(stdin)" failed (Failed to parse pipeline: line 850: did not find expected key)
  🚨 Error: The command exited with status 1
  user command error: exit status 1

================
Comment at: libcxx/include/__config:134
 // are deprecated.
-#    if defined(__FreeBSD__)
+#    if defined(__FreeBSD__) && !defined(_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR)
 #      define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR
----------------
emaste wrote:
> should this part be committed independently?
Can we commit this separately first?

================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/last_write_time.pass.cpp:9

+// XFAIL: LIBCXX-FREEBSD-FIXME
+
----------------
fails to apply, `// XFAIL: LIBCXX-AIX-FIXME` has been added here (and neg_format.pass.cpp, pos_format.pass.cpp, thousands_sep.pass.cpp, get_one_wide.pass.cpp, get_one.pass.cpp)

will deal with this once buildkite is sorted out

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128084/new/

https://reviews.llvm.org/D128084