[libcxx-commits] [PATCH] D140022: [libc++][math.h] Remove __sun__ workarounds

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 14 06:33:27 PST 2022


philnik added a comment.

In D140022#3994928 <https://reviews.llvm.org/D140022#3994928>, @ldionne wrote:

> This is https://reviews.llvm.org/D138680 -- let's not duplicate this.

I wouldn't consider this a duplicate. It's a subset of what you try to do in D138680 <https://reviews.llvm.org/D138680>. Here I only remove workarounds that are problematic to changes I want to make to libc++ while D138680 <https://reviews.llvm.org/D138680> removes all support code for Solaris (and derivatives). For the workarounds I want to remove I also propose a proper fix on the Illumos side of things (I assume other Solaris versions can be fixed in a similar way), see my previous comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140022/new/

https://reviews.llvm.org/D140022



More information about the libcxx-commits mailing list