[libcxx-commits] [PATCH] D140022: [libc++][math.h] Remove __sun__ workarounds

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a subscriber: jperkin.
philnik added a comment.

@jperkin Looking at https://github.com/illumos/illumos-gate/blob/master/usr/src/head/iso/math_iso.h (I hope that's the correct code) it seems trivial to remove the `float`/`long double` overloads when included through libc++, or add a macro like `_ILLUMOS_NO_CPP_MATH_OVERLOADS` to disable them. This would also make it a lot easier to implement P0533R9 on your platform, since you wouldn't have to do anything (at least with libc++) and make it a lot simpler for libc++ to move the code around without having to add workarounds. I didn't look at what you do with libstdc++, but I'd be surprised if it wasn't easier to let them provide the overloads as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140022/new/

https://reviews.llvm.org/D140022