[libcxx-commits] [PATCH] D139164: [libc++] Add missing includes for __type_traits details

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D139164#3968888 <https://reviews.llvm.org/D139164#3968888>, @jloser wrote:

> Looks reasonable.  Do you see any value in adding a test that verifies each top-level include actually includes all of the granularized headers?  E.g. that `<type_traits>` does indeed include all of the header files in `<__type_traits>`?  I idly wonder if we have similar problems for any of the other top-level includes that have been granularized such as the ones reported by the following:
>
> <snip>

I think that would be useful, I love to have tooling that catches errors. Looking at the list this seems like an easy error to make. I recognize one file...

Thanks for the cleanup, LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139164/new/

https://reviews.llvm.org/D139164