[libcxx-commits] [PATCH] D139164: [libc++] Add missing includes for __type_traits details

[Joe Loser via Phabricator via libcxx-commits]

jloser added a comment.

Looks reasonable.  Do you see any value in adding a test that verifies each top-level include actually includes all of the granularized headers?  E.g. that `<type_traits>` does indeed include all of the header files in `<__type_traits>`?  I idly wonder if we have similar problems for any of the other top-level includes that have been granularized such as the ones reported by the following:

  find libcxx/include -type d -maxdepth 1 -name '__*'
  libcxx/include/__iterator
  libcxx/include/__memory
  libcxx/include/__support
  libcxx/include/__chrono
  libcxx/include/__numeric
  libcxx/include/__ranges
  libcxx/include/__type_traits
  libcxx/include/__variant
  libcxx/include/__compare
  libcxx/include/__concepts
  libcxx/include/__filesystem
  libcxx/include/__utility
  libcxx/include/__charconv
  libcxx/include/__tuple
  libcxx/include/__format
  libcxx/include/__algorithm
  libcxx/include/__ios
  libcxx/include/__functional
  libcxx/include/__coroutine
  libcxx/include/__thread
  libcxx/include/__fwd
  libcxx/include/__memory_resource
  libcxx/include/__debug_utils
  libcxx/include/__bit
  libcxx/include/__string
  libcxx/include/__random

We can probably safely not worry about `__debug_utils` since it's private.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139164/new/

https://reviews.llvm.org/D139164