[libcxx-commits] [PATCH] D127695: WIP: clang: Implement Template Specialization Resugaring

[Matheus Izvekov via Phabricator via libcxx-commits]

mizvekov added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:377
+        CFLAGS: "-fcrash-diagnostics-dir=crash_diagnostics_dir"
+        CXXFLAGS: "-fcrash-diagnostics-dir=crash_diagnostics_dir"
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}"
----------------
Mordante wrote:
> I actually think this change would be nice for libc++ in general. I've has several assertion failures in the bootstrapping CI. Especially with the symbolizer available the crash reports become a lot better.
> 
> I'm not convinced the way you used the `CXXFLAGS` in the CMakeLists.txt is the best way, maybe @ldionne has a better suggestion.
Ah, this is just an idea at this point, this is not even working for crashes in lit-tests, the `LIBCXX_TEST_COMPILER_FLAGS` setting below did not seem to work.

I would really appreciate suggestions, but meanwhile I'll try to get something minimally working here and spin a separate DR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127695/new/

https://reviews.llvm.org/D127695