[libcxx-commits] [PATCH] D130471: [libc++] Granularize the rest of type_traits

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Please wait until ~ Thursday next week before shipping this. It touches a lot of stuff and I want to make cherry-picks for LLVM 15 as easy as possible.

Also, pending green CI as usual.



================
Comment at: libcxx/include/__fwd/hash.h:9
 
-#ifndef _LIBCPP_FWD_SPAN_H
-#define _LIBCPP_FWD_SPAN_H
+#ifndef _LIBCPP___FWD_SPAN_H
+#define _LIBCPP___FWD_SPAN_H
----------------
Please check the other files as well.


================
Comment at: libcxx/include/type_traits:422
 #include <__functional/invoke.h>
+#include <__fwd/hash.h>
 #include <__type_traits/add_const.h>
----------------
Per live review, can you please provide a link to a bug report regarding the poisoned hash helper test? This shouldn't be necessary.


================
Comment at: libcxx/include/type_traits:426
 #include <__type_traits/add_lvalue_reference.h>
 #include <__type_traits/add_pointer.h>
 #include <__type_traits/add_rvalue_reference.h>
----------------
You're missing an include of `can_extract_key.h`. I know it's not needed in `<type_traits>`, but we decided a while back that top-level headers would include all the files in their detail directory, so let's be consistent.

Per our discussion, it might make sense to change this approach to only include the public interface from our top-level headers, but let's not try to change the world in this commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130471/new/

https://reviews.llvm.org/D130471