[libcxx-commits] [PATCH] D132320: [libc++] Mark everything in <deque> as _LIBCPP_HIDE_FROM_ABI and replace _LIBCPP_INLINE_VISIBILITY

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D132320#3738090 <https://reviews.llvm.org/D132320#3738090>, @philnik wrote:

> In D132320#3738056 <https://reviews.llvm.org/D132320#3738056>, @Mordante wrote:
>
>> It wasn't clear from this patch that it was put on top of a "broken" patch. It would have been nice to add that as a hint for the reviewers.
>
> Sorry it wasn't clear. I thought the `Stack (1 Open)` makes it quite obvious.

I don't expect new patches on top of patches that don't compile, since that makes them fail too.
But the patch needs to be rebased anyway after the lower patch works again/is landed so will look at it then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132320/new/

https://reviews.llvm.org/D132320