[libcxx-commits] [PATCH] D132320: [libc++] Mark everything in <deque> as _LIBCPP_HIDE_FROM_ABI and replace _LIBCPP_INLINE_VISIBILITY

Sun Aug 21 08:41:40 PDT 2022

philnik added a comment.

In D132320#3738056 <https://reviews.llvm.org/D132320#3738056>, @Mordante wrote:

> In D132320#3738045 <https://reviews.llvm.org/D132320#3738045>, @philnik wrote:
>
>> In D132320#3738037 <https://reviews.llvm.org/D132320#3738037>, @Mordante wrote:
>>
>>> I only skimmed the file and see no direct oddities.
>>> But this patch is an ABI break on multiple platforms.
>>
>> It's not an ABI break. I added that test in the parent commit and didn't get the numbers right yet.
>
> It wasn't clear from this patch that it was put on top of a "broken" patch. It would have been nice to add that as a hint for the reviewers.

Sorry it wasn't clear. I thought the `Stack (1 Open)` makes it quite obvious.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132320/new/

https://reviews.llvm.org/D132320