[libcxx-commits] [PATCH] D132298: [libcxxabi][cmake] Allow building without libcxx again

[Kadir Cetinkaya via Phabricator via libcxx-commits]

kadircet added a comment.

Looks like the error messages didn't show up because expansion of `all` happened after the check. sent out D132454 <https://reviews.llvm.org/D132454> to fix it.

since libcxx(abi) can't be build through llvm_enable_projects, should we exclude it from the list in https://github.com/llvm/llvm-project/blob/main/llvm/CMakeLists.txt#L112 ?



================
Comment at: libcxxabi/CMakeLists.txt:136
     "Specify path to libc++ includes.")
+if (NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES)
+  if (NOT IS_DIRECTORY ${LIBCXXABI_LIBCXX_INCLUDES})
----------------
kadircet wrote:
> `all` is also a possible value for `LLVM_ENABLE_RUNTIMES` (here and below, in test/CMakeLists.txt) can you get that fixed? [see](https://llvm.org/docs/CMake.html#:~:text=LLVM_ENABLE_RUNTIMES%3Dall)
okay this was happening because LLVM_ENABLE_PROJECTS=all would also include this directory, without going through runtimes, which performs the expansion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132298/new/

https://reviews.llvm.org/D132298