[libcxx-commits] [PATCH] D132298: [libcxxabi][cmake] Allow building without libcxx again

[Kadir Cetinkaya via Phabricator via libcxx-commits]

kadircet added a comment.

this is breaking builds with:
`cmake -G Ninja ../llvm "-DLLVM_ENABLE_PROJECTS=all" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_C_COMPILER=clang" "-DCMAKE_CXX_COMPILER=clang++"`

Looking at https://libcxx.llvm.org/BuildingLibcxx.html, I assume these have been deprecated for a while but there were no warnings from CMake. Moreover `LIBCXXABI_LIBCXX_INCLUDES` was not being used or required previously by default at all (and `LLVM_ENABLE_RUNTIMES`).

After this change it enforces either having `LLVM_ENABLE_RUNTIMES` or `LIBCXXABI_LIBCXX_INCLUDES` set in the build configuration to build libcxx. Since I am not familiar with libcxx I can't really say if that's the desired behavior. Can you explicitly verify that's the case (and if so tell me how the builds with the config mentioned above was working above? they weren't able to build libcxx at all?)



================
Comment at: libcxxabi/CMakeLists.txt:136
     "Specify path to libc++ includes.")
+if (NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES)
+  if (NOT IS_DIRECTORY ${LIBCXXABI_LIBCXX_INCLUDES})
----------------
`all` is also a possible value for `LLVM_ENABLE_RUNTIMES` (here and below, in test/CMakeLists.txt) can you get that fixed? [see](https://llvm.org/docs/CMake.html#:~:text=LLVM_ENABLE_RUNTIMES%3Dall)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132298/new/

https://reviews.llvm.org/D132298