[libcxx-commits] [PATCH] D130860: [libc++] Implement `operator<=>` for `filesystem::directory_entry`

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang added inline comments.


================
Comment at: libcxx/include/filesystem:218
+
+      // XXX
+      bool operator==(const directory_entry& rhs) const noexcept;
----------------
Mordante wrote:
> XXX ?? That's not in the standard I assume?
that's my marker for "I still need to change something here"... because if I forget to actually address it and don't remove the marker, reviewers will usually catch it - as you just did :)

in this case, I already did the intended changes: I added the `removed in` comments which were not there of the copy-pasted synopsis from the standard. But I forgot to remove the marker


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/comparisons.pass.cpp:34
+
+  AssertComparisonsAreNoexcept<path>();
+  AssertComparisonsReturnBool<path>();
----------------
Mordante wrote:
> I think in other test you tested only one of these asserts, but no real objection against testing both.
good point! Those should be checking `AssertComparisonsAreNoexcept<directory_entry>` instead of `AssertComparisonsAreNoexcept<path>`... damn copy-pasting...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130860/new/

https://reviews.llvm.org/D130860