[libcxx-commits] [PATCH] D130860: [libc++] Implement `operator<=>` for `filesystem::directory_entry`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo some comments.



================
Comment at: libcxx/include/filesystem:218
+
+      // XXX
+      bool operator==(const directory_entry& rhs) const noexcept;
----------------
XXX ?? That's not in the standard I assume?


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/comparisons.pass.cpp:34
+
+  AssertComparisonsAreNoexcept<path>();
+  AssertComparisonsReturnBool<path>();
----------------
I think in other test you tested only one of these asserts, but no real objection against testing both.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130860/new/

https://reviews.llvm.org/D130860