[libcxx-commits] [PATCH] D131836: [libc++][CI] increases constexpr evaluation limit.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/utils/libcxx/test/features.py:46
+          when=lambda cfg: hasCompileFlag(cfg, '-fconstexpr-steps=1'),
+          actions=[AddCompileFlag('-fconstexpr-steps=128000000')]),
+
----------------
Mordante wrote:
> philnik wrote:
> > Are we sure we want to bring this right to the maximum? This could increase the built time by 100x when you actually have bad code.
> I can remove one 0 and it still works, but I like to have a bit of a margin. Lowering it further fails in the test.
I'd be a lot more comfortable with "just" a 10x increase. We can still bump it higher if we really need to later. By that time we might want to consider adding some easy way to disable this for specific tests to not have the compiler working for ages just to let us know we have a bug in our code. The `ranges.transform.pass.cpp` test is already horrible to work in. I can't imagine how it would be if we needed this step limit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131836/new/

https://reviews.llvm.org/D131836