[libcxx-commits] [PATCH] D131836: [libc++][CI] increases constexpr evaluation limit.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante updated this revision to Diff 453314.
Mordante marked an inline comment as done.
Mordante added a comment.

Address review comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131836/new/

https://reviews.llvm.org/D131836

Files:
  libcxx/utils/libcxx/test/features.py


Index: libcxx/utils/libcxx/test/features.py
===================================================================
--- libcxx/utils/libcxx/test/features.py
+++ libcxx/utils/libcxx/test/features.py
@@ -44,6 +44,16 @@
           when=lambda cfg: hasCompileFlag(cfg, '-Wuser-defined-warnings'),
           actions=[AddCompileFlag('-Wuser-defined-warnings')]),
 
+  # The default maximum number of operations in a constexpr function are too
+  # small for some tests. A "correct" value has been determined empirically.
+  Feature(name='clang-constexpr-steps',
+          when=lambda cfg: hasCompileFlag(cfg, '-fconstexpr-steps=1'),
+          actions=[AddCompileFlag('-fconstexpr-steps=128000000')]),
+
+  Feature(name='gcc-constexpr-steps',
+          when=lambda cfg: hasCompileFlag(cfg, '-fconstexpr-ops-limit=1'),
+          actions=[AddCompileFlag('-fconstexpr-ops-limit=128000000')]),
+
   Feature(name='has-fblocks',                   when=lambda cfg: hasCompileFlag(cfg, '-fblocks')),
   Feature(name='-fsized-deallocation',          when=lambda cfg: hasCompileFlag(cfg, '-fsized-deallocation')),
   Feature(name='-faligned-allocation',          when=lambda cfg: hasCompileFlag(cfg, '-faligned-allocation')),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131836.453314.patch
Type: text/x-patch
Size: 1210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220817/2538d563/attachment-0001.bin>