[libcxx-commits] [PATCH] D131324: [libc++][CI] Updates and improves the Docker image.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/utils/ci/Dockerfile:73
 # Install clang-format
-RUN apt-get update && apt-get install -y clang-format-$LLVM_LATEST_VERSION
-RUN ln -s /usr/bin/clang-format-$LLVM_LATEST_VERSION /usr/bin/clang-format && [ -e $(readlink /usr/bin/clang-format) ]
-RUN ln -s /usr/bin/git-clang-format-$LLVM_LATEST_VERSION /usr/bin/git-clang-format && [ -e $(readlink /usr/bin/git-clang-format) ]
+# TODO Determine whether we want to use the lastest stable clang-format release or the ToT in our ToT builds
+# TODO LLVM 16 remove hard-coded version 14 and the symlinks
----------------
ldionne wrote:
> IMO we should always use the latest *stable* version of clang-format available. We shouldn't build it from source, though, that's overkill.
No we shouldn't build from source, but we could have used the ToT of the nightly builds.
Still I think using a non-moving target is better. That would make it easier to require formatting in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131324/new/

https://reviews.llvm.org/D131324